Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide the edit button in settings #137

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

endoanaconda
Copy link
Contributor

No description provided.

@Klap-in
Copy link
Collaborator

Klap-in commented Sep 27, 2014

You are also changing stuff in the cloud syntax.
Please provide descriptions of your changes, and their use cases.

Why should I hide the edit button?
Thanks.

@endoanaconda
Copy link
Contributor Author

sorry, I've mixed up the two commits, cloudcount is in an other pull req. this one is only about the added flag for hiding the editbutton in settings

Why should I hide the edit button?
1st:I dont want it to be seen for all users
2nd: using the edit button removed some of my content, didn't get why, but it does. I'd rather like to edit the raw data

@Klap-in
Copy link
Collaborator

Klap-in commented Oct 7, 2014

Personally, I'm not enthusiastic about this config setting. It adds one more config setting, for something that should the same as editing raw text but in a more user friendly manner.

@splitbrain what is your opinion?

btw what kind of content is removed by the entry editor?

@endoanaconda
Copy link
Contributor Author

  • I don't see the problem by having a choice in settings.
  • I prefere to edit in plaintext, some users might use the editbutton, this results in diffrent versions of the dataset (see below)

what kind of content is removed/changed by the entry editor

  • when I group the datafields into logical blocks, with an extra empty line in between, this gets removed
  • in consequence I have some pages (where edit button has been used) with no logical-blocks, the ones I change in plaintext remain in the same style. search and replace gets pretty annoying
    if i want to do mass changes over all files

example what I mean with logical blocks: Imagine you have 30 fields, then you want do give it some structure, so I started using logical blocks

field1 : abc
field2 : abc
field3 : abc

field4 : abc
field5 : abc
field6 : abc

field7 : abc
field8 : abc
field9 : abc
field10 : abc

sorry, this change is allready pulled in an other request, but came by mistake with this commit.
please remove this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants